Skip to content

Conversation

ulysses4ever
Copy link
Contributor

@ulysses4ever ulysses4ever commented Aug 15, 2025

Checklist

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (recommended) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script
    • Since I'm adding a little tree (DAG) of packages (rooted at liquidhaskell), I was only able to run this with a success on the single leaf of this DAG: smtlib-backends. All rest (transitively) depends on it, so since it's not on Stackage yet, verify-package doesn't seem helpful.
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)

@ulysses4ever ulysses4ever force-pushed the liquidhaskell-nightly branch 2 times, most recently from a53c080 to d812b31 Compare August 15, 2025 15:14
@ulysses4ever
Copy link
Contributor Author

I don't understand why liquid-fixpoint of version 8.10.7 (deprecated on Hackage and long outdated) is picked up by the CI script. Can someone help, please?

@ulysses4ever ulysses4ever force-pushed the liquidhaskell-nightly branch from d812b31 to d147735 Compare August 15, 2025 17:27
@ulysses4ever ulysses4ever force-pushed the liquidhaskell-nightly branch from d147735 to 5162c88 Compare August 15, 2025 17:36
@ulysses4ever
Copy link
Contributor Author

I don't understand why liquid-fixpoint of version 8.10.7 (deprecated on Hackage and long outdated) is picked up by the CI script. Can someone help, please?

Okay, I specified an exact version of liquid-fixpoint and that did the trick: CI is green now. It's not too bad (and liquidhaskell works with that single version only anyway), but I'd be curious to know why check.sh picked an ancient version of the library when I did not specify a version, if someone has energy to explain me.

@juhp
Copy link
Member

juhp commented Aug 16, 2025

Thanks for this, merging!

@juhp juhp merged commit e3543e2 into commercialhaskell:master Aug 16, 2025
1 check passed
@juhp
Copy link
Member

juhp commented Aug 16, 2025

I don't understand why liquid-fixpoint of version 8.10.7 (deprecated on Hackage and long outdated) is picked up by the CI script. Can someone help, please?

Okay, I specified an exact version of liquid-fixpoint and that did the trick: CI is green now. It's not too bad (and liquidhaskell works with that single version only anyway), but I'd be curious to know why check.sh picked an ancient version of the library when I did not specify a version, if someone has energy to explain me.

I am not sure either, sounds a bit strange indeed - perhaps we can relax it later, dunno

@juhp
Copy link
Member

juhp commented Aug 16, 2025

Ah, I wasn't fully paying attention - I know it is a bit confusing but curator just ignores (or rather is unaware of) deprecations... see commercialhaskell/curator#46

So for Stackage we simply need to hardcode liquid-fixpoint < 8.10.7 - at least until this is fixed someday.
It only affects a handful of packages anyway.

juhp added a commit that referenced this pull request Aug 16, 2025
juhp added a commit that referenced this pull request Aug 16, 2025
@juhp
Copy link
Member

juhp commented Aug 16, 2025

I wonder if we could get liquidhaskell into LTS too...

@ulysses4ever
Copy link
Contributor Author

So for Stackage we simply need to hardcode liquid-fixpoint < 8.10.7

Oh my, I didn't realize 8.10.7 doesn't have the leading zero, so it's the latest version. It all makes sense now.

Curator not accounting for depreciation isn't surprising at all: depreciation is a strange concept which we discuss on the cabal tracker a lot, and I believe it has spotting support across the whole ecosystem including cabal itself.

I wonder if we could get liquidhaskell into LTS too...

Yes, I'll submit a patch shortly (hopefully, over the weekend). Thank you!

@ulysses4ever
Copy link
Contributor Author

ulysses4ever commented Aug 17, 2025

@juhp how do I add it to an LTS exactly? I assumed it's opening an analogous PR against an lts* branch (e.g. lts24). But on Matrix I got a conflicting reply: something about other repositories...

Thank you for fixing the test suite problems btw: I could have done it myself.

@juhp
Copy link
Member

juhp commented Aug 17, 2025

No worries

Yes, we need to edit https://github.com/commercialhaskell/lts-haskell/blob/master/build-constraints/lts-24-build-constraints.yaml

Good idea to try building it locally first: stack --resolver lts build liquidhaskell liquid-fixpoint ...
(Also unfortunately the CI is not working there either currently.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants