-
Notifications
You must be signed in to change notification settings - Fork 822
re-enable liquidhaskell #7819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-enable liquidhaskell #7819
Conversation
a53c080
to
d812b31
Compare
I don't understand why liquid-fixpoint of version 8.10.7 (deprecated on Hackage and long outdated) is picked up by the CI script. Can someone help, please? |
d812b31
to
d147735
Compare
d147735
to
5162c88
Compare
Okay, I specified an exact version of |
Thanks for this, merging! |
I am not sure either, sounds a bit strange indeed - perhaps we can relax it later, dunno |
Ah, I wasn't fully paying attention - I know it is a bit confusing but curator just ignores (or rather is unaware of) deprecations... see commercialhaskell/curator#46 So for Stackage we simply need to hardcode |
I wonder if we could get liquidhaskell into LTS too... |
Oh my, I didn't realize 8.10.7 doesn't have the leading zero, so it's the latest version. It all makes sense now. Curator not accounting for depreciation isn't surprising at all: depreciation is a strange concept which we discuss on the cabal tracker a lot, and I believe it has spotting support across the whole ecosystem including cabal itself.
Yes, I'll submit a patch shortly (hopefully, over the weekend). Thank you! |
@juhp how do I add it to an LTS exactly? I assumed it's opening an analogous PR against an lts* branch (e.g. lts24). But on Matrix I got a conflicting reply: something about other repositories... Thank you for fixing the test suite problems btw: I could have done it myself. |
No worries Yes, we need to edit https://github.com/commercialhaskell/lts-haskell/blob/master/build-constraints/lts-24-build-constraints.yaml Good idea to try building it locally first: |
Checklist
add my-cool-package
(please don't mentionbuild-constraints.yml
)smtlib-backends
. All rest (transitively) depends on it, so since it's not on Stackage yet,verify-package
doesn't seem helpful.cabal update && cabal outdated
)